Add a custom field for the screenshot folder#108
Open
meilleur102 wants to merge 2 commits intothe-hideout:masterfrom
Open
Add a custom field for the screenshot folder#108meilleur102 wants to merge 2 commits intothe-hideout:masterfrom
meilleur102 wants to merge 2 commits intothe-hideout:masterfrom
Conversation
Member
|
That's for this PR. It looks like it includes the code for setting a custom screenshot folder, but I'm not seeing where the app is using that new value to detect screenshots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dont know why but the folder that was created in my Document was
Escape from Tarkov and the app was looking for Escape From Tarkov (capital F on From)
I add no error but the screenshot / map location was not working.
Instead of just changing the code locally for me I add the same kind of field for a custom screenshot folder (like you did for the custom logs folder)
Some refactor was done cause of the IDE setting so you can modify as you wish