Skip to content

merge back to upstream#2

Merged
thanhtunguet merged 11 commits intothanhtunguet:mainfrom
supavn:main
Sep 15, 2025
Merged

merge back to upstream#2
thanhtunguet merged 11 commits intothanhtunguet:mainfrom
supavn:main

Conversation

@thanhtunguet
Copy link
Copy Markdown
Owner

No description provided.

…mprove performance and maintainability. Refactor nestedObject and nestedList to use public fields.
…roving readability and maintainability. Update switch cases to utilize these constants for color token retrieval.
…, introducing backgroundColorKey for improved theme integration. Update EnumStatusBadge to utilize new keys while maintaining legacy support.
…date iOS deployment target to 13.0, add GoRouter dependency, and refactor main app structure for improved routing and theme management.
…he title text based on the provided token, improving visual consistency with the theme.
…y naming for clarity. Update variable names from resolvedBackground, resolvedText, and resolvedBorder to resolvedBackgroundColor, resolvedTextColor, and resolvedBorderColor. Maintain legacy support in EnumStatusBadge while enhancing theme integration.
@thanhtunguet thanhtunguet merged commit e11deaa into thanhtunguet:main Sep 15, 2025
2 checks passed
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

print('bgColor $bgKey');
print('textColor $textKey');
print('borderColor $borderKey');
print('---------------------\n\n');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unnecessary Debug Logging in Production

Debug print statements in TextStatusBadge log color key resolution details to the console on every render. This unwanted output is not suitable for production builds.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant