Installed effect scanner and selector tab#19
Open
ttshaw1 wants to merge 3 commits intothammer:mainfrom
Open
Conversation
Author
|
Added colors and category names for gen 1 pedals, i.e. looks good on my pedal. Also added saving results to localstorage. If someone owns multiple pedals the localstorage will confuse them. If the pedals have serial numbers the program can interrogate that's probably the best way to resolve that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial solution for #18 . A button to scan all the possible effects that could be loaded on your pedal and see what really is installed, useful for people who've edited their effects with Zoom Effect Manager, Zoom Firmware Editor, or something else. When the scan is done, a tab is added to the effect selector containing only the effects installed on your pedal.
"all possible effects" means that on a gen 1 (non-plus) MultiStomp, the code looks for effects from other gen 1 MultiStomps. On an MS+ or G2Four, it looks for effects from other MS+ and G2Four.
Lots of room for improvement:
And does this actually work on pedals besides a non-plus multistomp?