Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions main.py
Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Comment on lines +3 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't result in 10 stories for the user. Consider revising the loop variable and/or the ending range.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A for loop might be useful here since we already know how many times it runs

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Comment on lines +6 to +11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these to a data structure such as a dictionary might be useful for printing or organizing the story.

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have a typo for the variable. Did you mean second_noun?

print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
Comment on lines +13 to +21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A helper function might be useful here for printing the story. It would keep the main code cleaner.
Also, an f-string and a single print statement could be helpful for readability.

// Loop back to "loop = 1"
loop = loop + 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shorter way for this same code would be

loop += 1

Comment on lines +3 to +23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting all of this into a function that could be called for each story