Skip to content

Fix logging typo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tgenin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix logging typo #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a2764c
Fix azure list_blobs deprecated arg
tgenin Jun 5, 2024
6509aee
Merge pull request #218 from tgenin/fix-tests
antoinejeannot Jun 6, 2024
51deb4f
Fix logging typo
tgenin Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modelkit/assets/drivers/azure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def build_client(client_configuration: Dict[str, str]) -> BlobServiceClient:
@retry(**AZURE_RETRY_POLICY)
def iterate_objects(self, prefix=None):
container = self.client.get_container_client(self.bucket)
for blob in container.list_blobs(prefix=prefix):
for blob in container.list_blobs(name_starts_with=prefix):
yield blob["name"]

@retry(**AZURE_RETRY_POLICY)
Expand Down
2 changes: 1 addition & 1 deletion modelkit/assets/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def fetch_asset(
"Fetched asset",
name=spec.name,
version=spec.version,
from_cacke=asset_info.get("from_cache"),
from_cache=asset_info.get("from_cache"),
)

if not return_info:
Expand Down