Conversation
# Conflicts: # zeton/data_access/points.py
# Conflicts: # sql/01_db_init.sql # sql/02_insert_user_data.sql # tests/basic_data.sql # zeton/api/points.py # zeton/data_access/points.py
Collaborator
Author
|
@zakonfeniksa zauważyłem że lubujesz się w ctrl+c, ctrl+v ale jakiś 1 linijkowy opis kiedy CI ten błąd wyskoczył też by się przydał. |
Collaborator
|
Sorry zapomniałem przebudować bazę :) |
zakonfeniksa
approved these changes
Nov 27, 2019
tgbdc7
requested changes
Nov 29, 2019
Owner
tgbdc7
left a comment
tgbdc7
left a comment
There was a problem hiding this comment.
1.jak jesteśmy zalogowani jako dziecko, nie możemy dodać punktów, ani wykorzystać. Coś działą nie poprawnie,
2 wykorzystać request.referrer
| return True | ||
|
|
||
| @bp.route("/child/<child_id>/points/add/<points>/<exercise_id>", methods=['POST']) | ||
| @bp.route("/child/<child_id>/points/add/<points>/<exercise_id>/<is_detail>", methods=['POST']) |
Owner
There was a problem hiding this comment.
proponuję bez is_detail - można wykorzystać request.referrer
Comment on lines
+50
to
+53
| if is_detail == "0": | ||
| return redirect(url_for('views.child', child_id=child_id)) | ||
| else: | ||
| return redirect(url_for('views.task_detail', child_id=child_id)) |
Owner
There was a problem hiding this comment.
proponuję return redirect(request.referrer)
uprości i kod będzie bardziej czytelny .
Collaborator
Popieram. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raz jeszcze #82. Nowy branch, nowy PR. Na podstawie #81. Można sprawdzać