Skip to content

fix: Excluding erroneous terraform version #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rwwn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Excluding erroneous terraform version #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/checker/updates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,12 @@ func (c *Client) Versions(s source.Source) ([]*goversion.Version, error) {
}

func filterTerraformTags(s source.Source, versions []*goversion.Version) []*goversion.Version {
// This is dumb but hashicorp have left two random tags in their git repo for v11 and 26258 lol!!
// This is dumb but hashicorp have left three random tags in their git repo for v11, 26258 and 20240919 lol!!
// Here we simply remove these from the results.
vers := []*goversion.Version{}
if s.Git.Remote == "https://github.com/hashicorp/terraform.git" {
for _, v := range versions {
if v.String() != "11.0.0" && v.String() != "26258.0.0" {
if v.String() != "11.0.0" && v.String() != "26258.0.0" && v.String() != "20240919.0.0" {
vers = append(vers, v)
}
}
Expand Down