Skip to content

feat(dursto): Make ID used in Node and Tree generic#795

Open
NSant215 wants to merge 3 commits intosantnr/resolver-falliblefrom
santnr/id-generic
Open

feat(dursto): Make ID used in Node and Tree generic#795
NSant215 wants to merge 3 commits intosantnr/resolver-falliblefrom
santnr/id-generic

Conversation

@NSant215
Copy link
Contributor

@NSant215 NSant215 commented Feb 9, 2026

Closes RV-894.
Relates to RV-892.

What

  • introduces the generic Id parameter for all functions using the Resolver to resolve an ID to the underlying object.
  • adds a test to ensure that a fallible resolver can produce the expected error.

Why

This brings us closer to enabling lazy loading of nodes.

Manually Testing

make all

Regressions

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.09%. Comparing base (64719e8) to head (b1db643).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           santnr/resolver-fallible     #795   +/-   ##
=========================================================
  Coverage                     91.09%   91.09%           
=========================================================
  Files                           110      110           
  Lines                         20913    20913           
  Branches                      20913    20913           
=========================================================
  Hits                          19050    19050           
  Misses                         1490     1490           
  Partials                        373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NSant215 NSant215 force-pushed the santnr/id-generic branch 15 times, most recently from 3b2b234 to 374936f Compare February 11, 2026 15:24
@NSant215 NSant215 changed the base branch from main to santnr/resolver-fallible February 11, 2026 15:25
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from e3ce608 to 1286291 Compare February 11, 2026 17:21
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 1286291 to 88cdd62 Compare February 12, 2026 08:51
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 54fc0a4 to 9b75ee0 Compare February 12, 2026 11:44
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 88cdd62 to 0db6457 Compare February 12, 2026 11:44
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from e6c2920 to f37695c Compare February 12, 2026 14:54
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 0db6457 to 6302eda Compare February 12, 2026 15:23
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 6302eda to 2415214 Compare February 12, 2026 17:27
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 34bd3e9 to f68efa1 Compare February 12, 2026 17:43
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from b139a3b to 4807f6f Compare February 13, 2026 09:33
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 5bd9e5a to a8170ad Compare February 13, 2026 09:49
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 4807f6f to a178c3b Compare February 13, 2026 11:34
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from a178c3b to 0e20387 Compare February 13, 2026 13:59
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 646f9e8 to 1561733 Compare February 13, 2026 15:53
@NSant215 NSant215 marked this pull request as ready for review February 13, 2026 15:53
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Benchmark results for revision edc4461:

Metric Duration TPS
Mean 1.528432605s 26.172
Worst 1.570101642s 25.476
Best 1.517773203s 26.354
Standard Deviation ±10.564932ms ±0.177
Full results
Run Transfers Duration TPS
1 40 1.570101642s 25.476
2 40 1.523005205s 26.264
3 40 1.524467968s 26.239
4 40 1.521063687s 26.297
5 40 1.520890713s 26.300
6 40 1.532045307s 26.109
7 40 1.521802972s 26.285
8 40 1.524800519s 26.233
9 40 1.53086131s 26.129
10 40 1.531194935s 26.123
11 40 1.517773203s 26.354
12 40 1.526847922s 26.198
13 40 1.533843587s 26.078
14 40 1.525211984s 26.226
15 40 1.527187612s 26.192
16 40 1.526469771s 26.204
17 40 1.522895048s 26.266
18 40 1.534101387s 26.074
19 40 1.523293965s 26.259
20 40 1.530793373s 26.130

Compare the results above with those for the default branch.

@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 0e20387 to 242ba46 Compare February 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant