Open
Conversation
krishna-404
requested changes
Apr 27, 2025
Comment on lines
+63
to
65
| "dependencies": { | ||
| "react-icons": "^5.5.0" | ||
| } |
Member
There was a problem hiding this comment.
shouldnt this be dev-dependency?
Comment on lines
+22
to
+26
| tableProps: Omit<MaterialReactTableProps<T>, 'columns' | 'data'> & { | ||
| columns: MRT_ColumnDef<T>[]; | ||
| data: T[]; | ||
| }, | ||
| table?: MRT_TableInstance<T> |
| }, | ||
| table?: MRT_TableInstance<T> | ||
| }) => { | ||
| const { columns, data, ...tablePropsWithoutColumnsAndData } = tableProps; |
Member
There was a problem hiding this comment.
why remove columns, data, seperately?
Comment on lines
+47
to
+56
| state={table.getState()} | ||
| columns={table.options.columns} | ||
| data={table.options.data} | ||
| enableColumnFilters={table.options.enableColumnFilters} | ||
| enableGlobalFilter={table.options.enableGlobalFilter} | ||
| enableColumnOrdering={table.options.enableColumnOrdering} | ||
| enableGrouping={table.options.enableGrouping} | ||
| enablePagination={table.options.enablePagination} | ||
| enableSorting={table.options.enableSorting} | ||
| // Add more table props as needed |
Member
Author
There was a problem hiding this comment.
passing table = {table} is overriding the pdf button and other props we pass.
This way buttons are showing, but from table actions we can't change table state, it has to be done via api.
How to solve this?
Member
Author
There was a problem hiding this comment.
passing table = {table} is overriding the pdf button and other props we pass.
This way buttons are showing, but from table actions we can't change table state, it has to be done via api.
How to solve this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.