Fix opening files in Safari #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that iOS Safari requires file input clicks to happen synchronously within the same call stack as the user's gesture. The previous implementation showed a modal dialog before opening the file picker, which broke the user gesture chain on iOS Safari. Changes: - Refactored file-handler.ts to separate file selection from file loading - Created new selectFile() function that returns file content without immediately loading it - Updated click handlers to reverse the flow: select file first (within user gesture), then check for unsaved changes, then load the file - This maintains iOS Safari compatibility while keeping the polished UX with Bootstrap modals The new flow is actually better UX: users can browse for files before committing to discard changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.