Sanitize user fields, posts comments, and meta values against XSS attacks #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texpert
changed the title
…the model, so use JSON.generate(value), which is not escaping, instead of value.to_json, which is using ActiveSupport's escaping method `to_json`
…ons to not automatically dismiss user prompts like alerts or modals. Also set increased `Capybara::Lockstep.timeout = 10` and `Capybara::Lockstep.timeout_with = :error`
…ove redundant `rails_helper` from all the specs. Also add `RSpec.` to specs' `describe` to avoid polluting the common object-space.
texpert
force-pushed
the
sanitize-user-fields-and-post-comments-against-xss
branch
from
dd9b052 to
bc64da1
Compare
texpert
force-pushed
the
sanitize-user-fields-and-post-comments-against-xss
branch
from
a4a9a03 to
257abfc
Compare
…`, because JSON.generate and fast_generate is escaping ActionController::Parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.