Feature/donor wall style tweaks 1 #1256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…days worth of data. Currently have debug data output for created day for each donation record
matthewdylan
approved these changes
Jul 2, 2025
Contributor
matthewdylan
left a comment
matthewdylan
left a comment
There was a problem hiding this comment.
Looks good. Don't have the time to go through and vet all of the css but I'm sure it's good. Left a general question above.
|
|
||
| // Set base typography proportions for headers, paragraphs, etc. | ||
| // sizing variables in settings/_breakpoints.scss | ||
| h1 { |
Contributor
There was a problem hiding this comment.
Pretty sure these rules are being covered elsewhere but wanted to make sure you checked to see if these updates effected any of the other donor app pages.
Author
There was a problem hiding this comment.
There are some mild regressions on the /donate page, specifically around the h1 size. I'll address shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
/membersWhy are we doing this? How does it help us?
Continuing to work towards a port of the donor wall to this repository.
How should this be manually tested?
After running locally, go to localhost/members, compare to https://www.texastribune.org/support-us/donors-and-members/
How should this change be communicated to end users?
Are there any smells or added technical debt to note?
What are the relevant tickets?
Have you done the following, if applicable:
(optional: add explanation between parentheses)
TODOs / next steps: