-
Notifications
You must be signed in to change notification settings - Fork 5
Add Waco business membership form #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mostly bg image and commenting out some stuff
because linting errs
|
Review note |
looks better now
ashley-hebler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM! It's kinda cool to see the Waco branding scaling this way. I support the approach of duplication for the sake of getting this out the door. Also if we're following the rule of 3, this is technically in the clear 😈
Two flags:
- not code-related: Could you ping Anna C. about this if you haven't already?
- future change: Our thank you pages aren't really "product" aware, which has always been the case regardless of this PR. BUT I did notice that the waco one in particular refers to the "Waco Local News Initiative" which I think was just the name before the name. Fine to update that in a future PR IMO!
djpeacher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Records appeared in Stripe, Salesforce, Slack as expected.
Can do and noted! |
|
Thank you both for the quick reviews!!! |
What's this PR do?
Why are we doing this? How does it help us?
Gives a landing page for business membership signups.
How should this be manually tested?
How should this change be communicated to end users?
We'll let April and Melissa know since this request started with them.
Are there any smells or added technical debt to note?
There is plenty of room to clean this up. They needed a quick turnaround, so this was literally a plug-and-play to get the business page from TT to work on Waco, followed by a very rough clean-up.
What are the relevant tickets?
https://airtable.com/appyo1zuQd8f4hBVx/tbloNZu8GkM52NKFR/viwS1XPty68eK4Ett/rec3fbfROpJFkMJTf?blocks=hide
Have you done the following, if applicable:
(optional: add explanation between parentheses)
TODOs / next steps: