Skip to content

Conversation

@matthewdylan
Copy link
Contributor

What's this PR do?

Why are we doing this? How does it help us?

Gives a landing page for business membership signups.

How should this be manually tested?

  • Can run locally but probably easiest to start on Waco staging's business page
  • Try giving at different levels and track donations through the stripe -> salesforce -> slack flow

How should this change be communicated to end users?

We'll let April and Melissa know since this request started with them.

Are there any smells or added technical debt to note?

There is plenty of room to clean this up. They needed a quick turnaround, so this was literally a plug-and-play to get the business page from TT to work on Waco, followed by a very rough clean-up.

What are the relevant tickets?

https://airtable.com/appyo1zuQd8f4hBVx/tbloNZu8GkM52NKFR/viwS1XPty68eK4Ett/rec3fbfROpJFkMJTf?blocks=hide

Have you done the following, if applicable:

(optional: add explanation between parentheses)

  • Added automated tests? ( )
  • Tested manually on mobile? ( )
  • Checked BrowserStack? ( )
  • Checked for performance implications? ( )
  • Checked accessibility? ( )
  • Checked for security implications? ( )
  • Updated the documentation/wiki? ( )

TODOs / next steps:

  • your TODO here

mostly bg image and commenting out some stuff
@tribune-servers tribune-servers temporarily deployed to waco-donations-testing February 24, 2025 23:21 Inactive
@ashley-hebler
Copy link
Member

Review note
I just updated the test server to include the latest commits. I think it was potentially behind.
cc @djpeacher

looks better now
@tribune-servers tribune-servers temporarily deployed to waco-donations-testing February 25, 2025 15:17 Inactive
Copy link
Member

@ashley-hebler ashley-hebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM! It's kinda cool to see the Waco branding scaling this way. I support the approach of duplication for the sake of getting this out the door. Also if we're following the rule of 3, this is technically in the clear 😈

Two flags:

  • not code-related: Could you ping Anna C. about this if you haven't already?
  • future change: Our thank you pages aren't really "product" aware, which has always been the case regardless of this PR. BUT I did notice that the waco one in particular refers to the "Waco Local News Initiative" which I think was just the name before the name. Fine to update that in a future PR IMO!

Copy link
Contributor

@djpeacher djpeacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Records appeared in Stripe, Salesforce, Slack as expected.

@matthewdylan
Copy link
Contributor Author

All LGTM! It's kinda cool to see the Waco branding scaling this way. I support the approach of duplication for the sake of getting this out the door. Also if we're following the rule of 3, this is technically in the clear 😈

Two flags:

  • not code-related: Could you ping Anna C. about this if you haven't already?
  • future change: Our thank you pages aren't really "product" aware, which has always been the case regardless of this PR. BUT I did notice that the waco one in particular refers to the "Waco Local News Initiative" which I think was just the name before the name. Fine to update that in a future PR IMO!

Can do and noted!

@matthewdylan
Copy link
Contributor Author

Thank you both for the quick reviews!!!

@tribune-servers tribune-servers temporarily deployed to waco-donations-testing February 27, 2025 21:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants