Conversation
2dfb1a0 to
b9958b5
Compare
| # data: | ||
| # artifacts.taskrun.format: tekton | ||
| # artifacts.taskrun.storage: tekton | ||
| data: |
There was a problem hiding this comment.
remove this change before upstream PR
|
Few thoughts: There's DSSE envelopes being created by chains here: chains/pkg/chains/signing/wrap.go Line 128 in 7824cdc This is used here: Line 171 in 7824cdc And every payloader I looked at in tree has an implementation of This wrapped signer is being used here: Line 181 in 7824cdc And that envelope is being passed in as Line 205 in 7824cdc Reading through this makes it appear as though the envelope is being used as the signature object. I've spent the last bit of today setting up Tekton and chains locally to test this theory. I also don't see other storage backends patching kubernetes resources with annotations -- I'm not opposed to it but something that the Red Hat team may or may not bring up. |
PR Template
Changes
in-totoformat and default to thearchivistastorage backend.in-totoformat and default to thearchivistastorage backend.storage.archivista.urlto specify the Archivista service endpoint.Submitter Checklist
Release Notes
artifacts.taskrun.storageandartifacts.pipelinerun.storagenow support the valuearchivista.storage.archivista.urlhas been introduced to specify the Archivista service endpoint.Users upgrading to this release who wish to use Archivista must update their
chains-configConfigMap accordingly. Example: