Fix Dashcam installation in CI#10
Conversation
|
Which API key do you need? I can add one to this repo... |
|
@ericclemmons , ideally we'd have a test key such that we could record and upload a 1s video as part of PR validation / CI. Note that adding a secret to a public repo is tricky from a security perspective. You need to make sure that workflows are not automatically triggered on PRs from folks that don't have write access. |
|
We'd need at least an API key, and I think we also need a project ID to be able to stop the recording and upload the file. The name of the variable doesn't matter as long as we can access it from |
|
@ericclemmons Do I have your ✅ to merge? I'm used to waiting for one approval despite having merge rights, but let me know if we should work otherwise. |
|
@tristanlabelle Oh yessir! I'll go ahead & merge that now... |

Add missing params to the installation action. This allows CI to validate installation.
Unfortunately we can't start/stop recording because we don't have an API key, so I left the code with dummy values but added
continue-on-failure. Filed #11 as follow-up.