feat: Split http handler into sub projects #44

bruegth · 2025-10-04T21:23:37Z

Project changes:

splits httpHandler into different sub projects
adds NativeHttpHandler

API changes:

remove namedPipeConnectTimeout from config and hardcoded to 10s instead of 100ms

Test changes:

modify TestFixture to support dind and different clients
add dind for tls client tests to ci
add parallel test
add speed test
check for com.docker.service in Docker_IsRunning too (DockerDesktop for Windows)
add 1s sleep in MonitorEventsFiltered_Succeeds test

FollowUp:

investigate why parallel test for managed/legacy http handler fails when using TLS

add native http handler add WriteClosableStreamWrapper for native http handler move WriteClosableStream into base namespace add HijackStreamHelper for reflection (conflict with System member) remove namedPipeConnectTimeout from config and hardcoded to 10s instead of 100ms

modify TestFixture to support dind and different clients add dind for tls client tests to ci add parallel test add speed test check for com.docker.service in Docker_IsRunning too add 1s sleep in MonitorEventsFiltered_Succeeds test

remove http handler from base

bruegth · 2026-01-20T07:09:18Z

@HofmeisterAn Can you please review this PR too? Otherwise feel free to close this PR.

I'm using this for some months for now and no errors found.

Splitting handler into different packages make sense in my opinion.

With legacy custom http handler implementation, I'm still facing memory and CPU problems, so I will keep using my fork, because for me this is critical.

HofmeisterAn · 2026-01-20T07:24:33Z

Thanks for the heads-up. I haven't forgotten the PR. I started it but didn't finish because other things kept coming up, and it's a pretty big PR. I'll try to review it in the next few days. Sorry about that.

Splitting handler into different packages make sense in my opinion.

I agree 👍.

bruegth · 2026-01-20T07:29:39Z

Thanks for the heads-up. I haven't forgotten the PR. I started it but didn't finish because other things kept coming up, and it's a pretty big PR. I'll try to review it in the next few days. Sorry about that.

No worries, take your time.

I'm happy that you maintain this project. 👍🏻

HofmeisterAn

I think I can share the first part already. It would be great if we could reduce the copied classes by using a shared project or directory. This would make the review easier and help me see which classes were simply moved. Then I can continue with the actual content.

.github/workflows/ci.yml

src/Microsoft.Net.Http.Client/BufferedReadStream.cs

src/Docker.DotNet.NPipe/Microsoft.Net.Http.Client/BufferedReadStream.cs

README.md

src/Docker.DotNet/DockerPipeStream.cs

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

…gth/TestContainers.Docker.DotNet into split-handler

HofmeisterAn · 2026-01-23T17:25:12Z

@bruegth Thanks for taking care of the suggestions so quickly. I'll review the remaining parts on Sunday when my family is out.

…ndler

bruegth · 2026-01-26T19:17:50Z

TODOs:

Revert test changes
Change Readme (new env "DOCKER_DOTNET_USE_NATIVE_HTTP") + changes for packages)

HofmeisterAn

I think the sources look good. I have a few more questions, and could you please review the recent changes to see if they are OK for you? I will update the tests sometime over the weekend.

src/Docker.DotNet.X509/CertificateCredentials.cs

HofmeisterAn · 2026-01-28T08:08:36Z

src/Docker.DotNet.X509/CertificateCredentials.cs

+            nativeHandler.UseProxy = true;
+            nativeHandler.AllowAutoRedirect = true;
+            nativeHandler.MaxAutomaticRedirections = 20;
+            nativeHandler.Proxy = WebRequest.DefaultWebProxy;


question: Do we need the proxy configuration? I'm not sure if this is compatible with the already existing proxy "configurations":

DetermineProxyModeAndAddressLine(HttpRequestMessage)

TunnelThroughProxyAsync(HttpRequestMessage, Stream, CancellationToken)

I think we should move this to a separate PR (and make sure it is aligned with the exiting parts).

yes new PR for that will be good.

Also I think the default OS proxy settings also should be overwritten by some new configs in future.

Okay, then we need to clean this up (also remove reflection).

src/Docker.DotNet.LegacyHttp/DockerHandlerFactory.cs

src/Docker.DotNet.NativeHttp/WriteClosableStreamWrapper.cs

bruegth · 2026-01-29T10:50:42Z

I think the sources look good. I have a few more questions, and could you please review the recent changes to see if they are OK for you? I will update the tests sometime over the weekend.

Sure it's okay for me. Your fine-tuning looks good and makes sense.

bruegth · 2026-01-29T10:54:29Z

src/Docker.DotNet.Handler.Abstractions/Docker.DotNet.Handler.Abstractions.csproj

@@ -0,0 +1,18 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <AssemblyName>Docker.DotNet.Handler.Abstractions</AssemblyName>


Was the intention of new .Handler. package hierarchy to use it into e.g. npipe too?

I'm not sure if I understood the question correctly. There will likely be more implementations in the future, for example for SSH or gRPC. My idea was to put everything into the handler project that these implementations need to fulfill.

HofmeisterAn · 2026-01-30T18:19:12Z

I think we're almost done. Most tests passed, only 3/4 fail for the native implementation, which we need to check.

HofmeisterAn

Looks pretty good. Almost done I think.

HofmeisterAn · 2026-01-30T20:12:27Z

src/Docker.DotNet.X509/CertificateCredentials.cs

+            nativeHandler.UseProxy = true;
+            nativeHandler.AllowAutoRedirect = true;
+            nativeHandler.MaxAutomaticRedirections = 20;
+            nativeHandler.Proxy = WebRequest.DefaultWebProxy;


Okay, then we need to clean this up (also remove reflection).

HofmeisterAn · 2026-01-30T20:13:04Z

README.md

We need to update the README once more.

bruegth mentioned this pull request Oct 4, 2025

feat: add option to use native dotnet http handler for http(s) #35

Closed

bruegth added 2 commits October 8, 2025 09:46

test all docker clients

5eb5fa4

modify TestFixture to support dind and different clients add dind for tls client tests to ci add parallel test add speed test check for com.docker.service in Docker_IsRunning too add 1s sleep in MonitorEventsFiltered_Succeeds test

bruegth force-pushed the split-handler branch from cb770b3 to 5eb5fa4 Compare October 8, 2025 08:07

bruegth added 3 commits October 8, 2025 11:19

fix netstandard compile

301ce6e

remove http handler from base

fix factory assembly loading

80897ec

change README for new handler packages

d42ea2b

bruegth changed the title ~~Draft: Split handler~~ feat: Split http handler into sub projects Oct 10, 2025

HofmeisterAn reviewed Jan 22, 2026

View reviewed changes

bruegth and others added 10 commits January 23, 2026 07:34

Update docker image version

ff63964

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

Fix spelling

88e394c

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

Update README.md

aca9de5

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

Update README.md

ddedc3d

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

Update README.md

208590b

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

fix setup matrix

79f6847

deduplicate ms code into shared project

1c6cebd

Merge branches 'split-handler' and 'split-handler' of github.com:brue…

b15d6ba

…gth/TestContainers.Docker.DotNet into split-handler

ignore CA1416 (Plattform windows)

7e08128

remove usings

e1fd807

HofmeisterAn added 7 commits January 24, 2026 07:38

chore: Order project references and usings

cb852a4

chore: Add Enhanced to package id to keep packages together

17a89ad

chore: Align descriptions

c78d837

chore: Align shared project

f1d5da4

chore: Remove BOM

fc4b73b

Merge remote-tracking branch 'origin/main' into fork/bruegth/split-ha…

8748100

…ndler

chore: Order csproj

91b982f

fix: Set correct certs path

c6aa1f4

HofmeisterAn mentioned this pull request Jan 25, 2026

feat: Modernize ManagedHandler for proxy compatibility while preserving hijacked streams #53

Open

4 tasks

remove reflection and dynamic loading

3e7b93b

bruegth force-pushed the split-handler branch from b2bd8d7 to 3e7b93b Compare January 26, 2026 19:30

HofmeisterAn added 8 commits January 28, 2026 17:41

chore: Rename HandlerFactory to Handler.Abstractions

5ec38a5

feat: Add CPM

740e890

chore: Align namespace

a366428

chore: Remove unnecessary changes

9cf86e2

chore: Turn handler to singleton

f255cb4

chore: Add IStreamHijacker

f1268db

chore: Read env var once

be2d695

chore: Add description

22d6432

HofmeisterAn reviewed Jan 29, 2026

View reviewed changes

bruegth commented Jan 29, 2026

View reviewed changes

HofmeisterAn added 10 commits January 29, 2026 19:50

chore: Order sln projects

ad32e4e

fix: Revert test changes

260e3e0

feat: Pass configurations to test

cc1c61a

feat: Support Docker env var

55e68be

chore: Remove unused enums

899f384

chore: Order projects in sln file

7b6256b

feat: Load the CA properly

6cb63f3

feat: Add DockerTlsCertificates

4ea4b87

fix: Import/export on Windows

d3fb09d

fix: CryptographicException

70decf4

HofmeisterAn added 2 commits January 30, 2026 20:47

fix: Assert base exception

3c056b5

fix: Wait for monitoring

0bc0a30

HofmeisterAn requested changes Jan 30, 2026

View reviewed changes

Uh oh!

feat: Split http handler into sub projects #44

Are you sure you want to change the base?

feat: Split http handler into sub projects #44

Conversation

bruegth commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bruegth commented Jan 20, 2026

Uh oh!

HofmeisterAn commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bruegth commented Jan 20, 2026

Uh oh!

HofmeisterAn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HofmeisterAn commented Jan 23, 2026

Uh oh!

bruegth commented Jan 26, 2026

Uh oh!

HofmeisterAn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HofmeisterAn Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

bruegth Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

HofmeisterAn Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bruegth commented Jan 29, 2026

Uh oh!

bruegth Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HofmeisterAn Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

HofmeisterAn commented Jan 30, 2026

Uh oh!

HofmeisterAn left a comment

Choose a reason for hiding this comment

Uh oh!

HofmeisterAn Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

HofmeisterAn Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bruegth commented Oct 4, 2025 •

edited

Loading

HofmeisterAn commented Jan 20, 2026 •

edited

Loading

bruegth Jan 29, 2026 •

edited

Loading