Open
Conversation
Python2 allows `<int> < None` which evaluates to False. In Python3 this raises an exception. See: https://crbug.com/1296209 Initializing with 0 preserves the logic and works in both Python versions.
Contributor
|
Ping @jugglinmike |
|
I am blocked by this in v8. |
|
Ping @jugglinmike |
|
@leobalter could you approve and merge this. we got blocked by this in v8. |
cclauss
added a commit
to cclauss/test262-harness-py
that referenced
this pull request
Apr 15, 2023
|
Proven in #13 and used there to fix failing pytests. |
cclauss
approved these changes
Apr 15, 2023
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
This is an essential change for Python 3.
Ms2ger
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python2 allows
<int> < Nonewhich evaluates to False. In Python3 this raises an exception. See:https://crbug.com/1296209
Initializing with 0 preserves the logic and works in both Python versions.