Skip to content

Row/column logic tweaks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ben-cassese wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Row/column logic tweaks #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b864ba5
swap axis order in wcs for predicted sectors
ben-cassese Feb 22, 2026
cda1d3c
swap rows/columns in overscan correction
ben-cassese Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tesswcs/locate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ def get_observability_mask(wcs: WCS, coords: SkyCoord):
).T
# Update the mask with those pixels
j = (
(C >= 0)
& (R >= 44)
& (C <= (wcs._naxis[0] - 30))
& (R <= (wcs._naxis[1] - 44))
(C >= 44)
& (R >= 0)
& (C <= (wcs._naxis[0] - 44))
& (R <= (wcs._naxis[1] - 30))
)
k[k] = j
return k
Expand Down
3 changes: 1 addition & 2 deletions src/tesswcs/tesswcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def from_sector(cls, sector: int, camera: int, ccd: int):
wcs.ra = cls.wcs_dicts[sector]["ra"]
wcs.dec = cls.wcs_dicts[sector]["dec"]
wcs.roll = cls.wcs_dicts[sector]["roll"]
# This looks wrong because wcs is column major
wcs.pixel_shape = (rcolumns, rrows)
wcs.wcs.ctype = ["RA---TAN-SIP", "DEC--TAN-SIP"]
wcs.wcs.cunit = ["deg", "deg"]
Expand Down Expand Up @@ -118,7 +117,7 @@ def predict(
# initialize object
wcs = cls(naxis=2)
wcs.ra, wcs.dec, wcs.roll, wcs.camera, wcs.ccd = ra, dec, roll, camera, ccd
wcs.pixel_shape = (rrows, rcolumns)
wcs.pixel_shape = (rcolumns, rrows)

# center of the CCD
xc, yc = cls.xcent[camera][ccd], cls.ycent[camera][ccd]
Expand Down
Loading