WIP: Target List Creation for the TESS GI Proposal Call

[tylerapritchard]

This is a WIP for adding a target list creation function to the tessproposaltool built off the fill_tics functionaliy by @christinahedges . It allows you to give a mixed csv (see tests/data/test5.csv) or dataframe of ra,dec,(tmag) or TIC and returns an ARK-compatible target list csv file (or dataframe). It currently allows you to provide optional colums and will choose sane defaults for optional columns if they are not provided.

TODO:

• More tests, and more robust tests
• Documentation
• add crossmatch diagnostics to the remarks column
• review dictionaries for potential column names we want to accept/disambiguate
• verify the CSV itself works on ark as expected (we might need to pull the header or write a custom comment header)
• Should we add more optional inputs for web-based gui functionality with the flask frontend @rebekah9969 ?

[tylerapritchard]

From our discussions about edge case testing:

• Someone uploads a non csv file
  This should get flagged by the web tool. if read_csv cant parse the file we'll get an error

• uploads a file with one row
  This will be processed normally. If this row is just a header we'll process this regularly an if the header is valid return an empty targetlist with no data and throw a warning. If it is a header + one line of data it will work as per usual.

• uploads a file with no headers
  This will throw an exception. We require headers that we can disambiguate.

• uploads a file with extra columns
  These columns will be removed. No error or warning is thrown.

• uploads a file with only headers
  If this row is just a header we'll process this regularly an if the header is valid return an empty targetlist with no data and throw a warning.

• uploads a file with miss-spelled headers
  Right now we have a limited disambiguation for headers in there, but it certainly doesn't account for all options. If tic or ra and dec is missing we throw an error. If an optional header is not found we throw a warning.

• file has no targets observable in C8
  We are not currently including an observability check in here. I am concerned about scope-creep here, but we certainly can. If we go this route we should discuss if we want to incorporate the more full "technical review" component I have in PR WIP: Adding technical reviews / target list summaries to tessproposaltool #1 . I think the workflow should be something like targetlist->technical review-> user review -> user modification & repeat

• tics but no ra/decs
  works

• ra/decs but no tics
  works

other things:

• some mix of tics and ra, decs
  works

• large separations in the corss-match that might be unreliable
  I've added warnings for large separation values in the cross-match (>3).