-
Notifications
You must be signed in to change notification settings - Fork 6
Update comments #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Update comments #22
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
79cb994
Fix comments in fits
Nschanche a3d3cb6
ruff
Nschanche 1089abc
Update aiohttp poetry
Nschanche 5578696
Update poetry
Nschanche dfbc8ca
Update documentation.yml
Nschanche f405169
Revert documentation.yml
Nschanche 7c9db81
revert changes to poetry
Nschanche 3839d9a
Merge remote-tracking branch 'origin/main' into comments
Nschanche 2a6f712
ruff
Nschanche 262cb6c
remove comments
Nschanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be separate from this PR, as I think this line is reproducing the previous behavior - but are we sure that this is what we want?
This looks to me like we're grabbing the first FFI name that's in the cube that has a time after the requested time. But I think the FFI times are midpoints, so in some cases we might return the wrong exposure. We might want to find the ffi-midpoint time that's closest to our time instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this reproduces existing behavior. That is something we could do if you prefer. But that would be a separate issue.