Skip to content

Conversation

@Roms1383
Copy link
Contributor

If ever you feel like jumping the leap :)

  • update Cargo edition to 2024
  • update Rust compiler version to 1.89.0
  • fix lint issues on newer versions
  • update dependencies to latest versions
  • migrate from paste to pastey as recommended

@Roms1383 Roms1383 marked this pull request as draft August 11, 2025 06:25
@Roms1383
Copy link
Contributor Author

Also:

  • update clippy checks job
  • update run tests job

@Roms1383 Roms1383 marked this pull request as ready for review August 11, 2025 07:25
@Roms1383 Roms1383 marked this pull request as draft August 11, 2025 07:43
@Roms1383
Copy link
Contributor Author

In last test I run 2 rustc compiler versions (and we could do the same for edition) but I wonder if it's that useful.
What do you think overall @tesselode ?

@tesselode
Copy link
Owner

@Roms1383 is there much of an extra maintenance burden to specifying an MSRV? what's the best practice for making sure the crate works on that version? is it good enough to just run the CI actions using the MSRV?

@Roms1383
Copy link
Contributor Author

Roms1383 commented Sep 6, 2025

MSRV or rust-version is simply the minimal Rust version required to use a crate: I haven't specified any since it would force kira's crate users to bump their minimal Rust version, which can be both annoying and sometimes outright impossible.

Editions, on the other hand, are backward compatibles so it won't require any change from kira's users.

Finally, making sure kira works perfectly on a specific Rust version (or multiple ones)in Github CI workflows is enough. The only question is whether you'd rather test 'a single version (usually the latest) in this case I can do the appropriate change, or whether you like the idea of testing multiples ones (like 1.85.0 and latest 1.89.0 atm), but it does consume more CI minutes of course, which you might want to avoid.

@Roms1383 Roms1383 marked this pull request as ready for review September 6, 2025 08:44
@tesselode tesselode merged commit c40ceab into tesselode:main Sep 21, 2025
24 checks passed
@tesselode
Copy link
Owner

thank you!

@Roms1383 Roms1383 deleted the chore/next branch September 22, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants