Open
Conversation
…)" This reverts commit 8cb471e.
|
767a9d1 to
e1b948d
Compare
mrginglymus
commented
Dec 17, 2025
| export function defaultAliasTransform(token: TokenNormalized) { | ||
| export function defaultAliasTransform(token: TokenNormalized | undefined) { | ||
| if (!token) { | ||
| throw new Error('Undefined token'); |
Contributor
Author
There was a problem hiding this comment.
This still isn't a huge improvement as we don't know what the token originally was...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reworking of #621
I realised that the default
transformAliasdoes throw errors on undefined:terrazzo/packages/token-tools/src/css/lib.ts
Lines 6 to 9 in 8cb471e
However, when a user-provided function is given, this assertion is lost.
Instead of having to update every transform, update the entrypoint to wrap any user-provided
transformAliaswith an assertion. This means we can burn a lot more!.How to Review
How can a reviewer review your changes? What should be kept in mind for this review?