fix(plugin-swift): Fixes plugin import error#544
fix(plugin-swift): Fixes plugin import error#544pvignau wants to merge 1 commit intoterrazzoapp:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 4a14132 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pvignau
force-pushed
the
fix/issue-535
branch
from
329f3d6 to
4a14132
Compare
| }; | ||
| } | ||
|
|
||
| const toP3 = toGamut('p3', 'oklch'); |
There was a problem hiding this comment.
Oh I think I know what’s happening—Culori relies on side effects to set up, which isn’t great, but just how it works.
Does this work if instead of this, we just added import "culori/css" like here?
The thing I’m worried about is, deferring the load till later doesn’t change the setup; it almost seems like it just relies on something else to load the side effect. So if that changed, then this would break again.
Instead, if we find the necessary setup for the original code to work, then that means this plugin is self-dependent and doesn’t need to be loaded in a specific order to work.
2 participants
Changes
Fixes #535
Deffering
toP3function var creation fixes the✗ [config] Cannot read properties of undefined (reading 'channels')error when importing the plugin.How to Review