Skip to content

Conversation

@john-science
Copy link
Member

@john-science john-science commented Feb 5, 2025

What is the change?

Here I add a "QA Documentation" section to the ARMI docs. This section will have:

  • Open-Sourced ARMI Requirements
  • Software Requirements Specification Document (SRSD)
  • Software Design and Implementation Document (SDID)
  • Software Test Report (STR)

Why is the change being made?

close #2064

This is part of on-going work to improve the documentation of ARMI's high-level design requirements, and to open-source that information.

SCR Information

Change Type: docs

One-Sentence Description: Here I add a "QA Documentation" section to the ARMI docs.

One-line Impact on Requirements: NA


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the documentation Improvements or additions to documentation label Feb 5, 2025
@john-science
Copy link
Member Author

Okay, this appears to work fine. Here are some examples. First, the TOC at the top now includes this:

image

The sphinx-needs tooling is working:

image

image

The SDID looks fine:

image

The STR matrix is working:

image

image

@john-science
Copy link
Member Author

Okay, this is working great.

But I am now getting a TON of Sphinx warnings:

WARNING: Ignored `filter:progid:DXImageTransform.Microsoft.gradient(GradientType=0,StartColorStr="#f9f9f9", EndColorStr="#e0e0e0")` at 16:4443, unknown property.
WARNING: Ignored `text-shadow:0 1px 0 #c4def1` at 16:4687, unknown property.
WARNING: Ignored `background-image:-webkit-linear-gradient(top, #bddef4 0%, #79ace9 100%)` at 16:4753, invalid value.
WARNING: Ignored `background-image:-o-linear-gradient(top, #f0f0f0 0%, #dadada 100%)` at 16:6528, invalid value.
WARNING: Ignored `filter:progid:DXImageTransform.Microsoft.gradient(GradientType=0,StartColorStr="#f0f0f0", 
WARNING: Ignored `box-shadow:0 0 3px #444` at 28:2080, unknown property.
WARNING: Anchor defined twice: 'setting-up-the-blueprints'
WARNING: Anchor defined twice: 'nuclide-flags'
WARNING: Anchor defined twice: 'defining-fuel-management'
WARNING: Anchor defined twice: 'id13'
WARNING: Anchor defined twice: 'new-features'
WARNING: Anchor defined twice: 'api-changes'
WARNING: Anchor defined twice: 'bug-fixes'
WARNING: Anchor defined twice: 'quality-work'
WARNING: Anchor defined twice: 'bug-fixes'
WARNING: Anchor defined twice: 'quality-work'
WARNING: Anchor defined twice: 'subpackages'
WARNING: Anchor defined twice: 'submodules'
WARNING: Anchor defined twice: 'T_ARMI_MAT_PROPERTIES1'
WARNING: Anchor defined twice: 'T_ARMI_MAT_FLUID0'
WARNING: Anchor defined twice: 'submodules'
WARNING: Anchor defined twice: 'id1'
WARNING: Anchor defined twice: 'id2'
WARNING: Anchor defined twice: 'I_ARMI_MAT_FLUID'

The docs look fine though.

@john-science john-science requested a review from ntouran February 7, 2025 18:39
@john-science john-science marked this pull request as ready for review February 27, 2025 18:41
@opotowsky
Copy link
Member

Okay, this is working great.

But I am now getting a TON of Sphinx warnings:

WARNING: Ignored `filter:progid:DXImageTransform.Microsoft.gradient(GradientType=0,StartColorStr="#f9f9f9", EndColorStr="#e0e0e0")` at 16:4443, unknown property.
WARNING: Ignored `text-shadow:0 1px 0 #c4def1` at 16:4687, unknown property.
WARNING: Ignored `background-image:-webkit-linear-gradient(top, #bddef4 0%, #79ace9 100%)` at 16:4753, invalid value.
WARNING: Ignored `background-image:-o-linear-gradient(top, #f0f0f0 0%, #dadada 100%)` at 16:6528, invalid value.
WARNING: Ignored `filter:progid:DXImageTransform.Microsoft.gradient(GradientType=0,StartColorStr="#f0f0f0", 
WARNING: Ignored `box-shadow:0 0 3px #444` at 28:2080, unknown property.
WARNING: Anchor defined twice: 'setting-up-the-blueprints'
WARNING: Anchor defined twice: 'nuclide-flags'
WARNING: Anchor defined twice: 'defining-fuel-management'
WARNING: Anchor defined twice: 'id13'
WARNING: Anchor defined twice: 'new-features'
WARNING: Anchor defined twice: 'api-changes'
WARNING: Anchor defined twice: 'bug-fixes'
WARNING: Anchor defined twice: 'quality-work'
WARNING: Anchor defined twice: 'bug-fixes'
WARNING: Anchor defined twice: 'quality-work'
WARNING: Anchor defined twice: 'subpackages'
WARNING: Anchor defined twice: 'submodules'
WARNING: Anchor defined twice: 'T_ARMI_MAT_PROPERTIES1'
WARNING: Anchor defined twice: 'T_ARMI_MAT_FLUID0'
WARNING: Anchor defined twice: 'submodules'
WARNING: Anchor defined twice: 'id1'
WARNING: Anchor defined twice: 'id2'
WARNING: Anchor defined twice: 'I_ARMI_MAT_FLUID'

The docs look fine though.

This is probably because you have a file getting processed by sphinx 2x somewhere via an include. If you add that file to exclude_patterns in your conf.py you should be able to get rid of these. I think. I've spent 0 time confirming this.

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review this at the high level (not commenting on content since that is being reviewed by @ntouran)

There are minor formatting issues with the PDF (some tables and text includes run off the page, and some math isn't rendering in the PDF that renders fine in HTML. I sent screencaps to you offline.

In the QA section (HTML), it appears I can click from an impl or test back to a requirement, but I can't click the impl/test link from the requirement (I get a "page does not exist" error).

Looks good though! Let me know if some of these things I commented on are out of scope.

@john-science john-science removed the request for review from ntouran March 5, 2025 02:21
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok after all the troubleshooting, I re-approve!

@john-science john-science merged commit 66cac55 into main Mar 6, 2025
17 checks passed
@john-science john-science deleted the qa_docs branch March 6, 2025 17:54
drewj-tp added a commit that referenced this pull request Mar 21, 2025
* main: (26 commits)
  Adding Requirements and QA to Docs (#2076)
  Applying expansion for material composition changes (#2077)
  Accounting for symmetry factor in `getMgFlux` (#2086)
  Solving test warnings (#2084)
  Accounting for parent symmetry in component flux calc (#2068)
  Improving HexBlock.rotate() docstring (#2083)
  Improving wetted perimeter calc for depletable components (#2067)
  Implementing more detailed `__lt__` for components. (#1882)
  Expanding allowable XS types to include lower case letters (#2069)
  Making sure SFPs have spatial grids (#2082)
  Removing silent overwrite of `shutil.copy` (#2081)
  Removing commit msg checkbox from PR template (#2078)
  Removing an unhelpful comment (#2079)
  Revamping Requirements (#2074)
  Ignoring Fluid density warning for Component Fluids (#2075)
  Update doc build to py313 (#2050)
  Fix out of date assumption on AZS IDs for "natural nuclides" (#2049)
  Making material modifications more robust against type errors (#2046)
  Fixing custom isotopics for Fluids (#2071)
  Loosening tolerance on HexGrid roughly equal check (#2058)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open-Source ARMI's Requirements

3 participants