This repository was archived by the owner on Nov 19, 2021. It is now read-only.
Hide non-unicode emoji when outputting to unicode#18
Open
nmeierpolys wants to merge 13 commits intoterranisu:masterfrom
Open
Hide non-unicode emoji when outputting to unicode#18nmeierpolys wants to merge 13 commits intoterranisu:masterfrom
nmeierpolys wants to merge 13 commits intoterranisu:masterfrom
Conversation
…ters into a reusable service
…e positioning option
When this merges, would you mind tagging this commit with 0.3.0 so the bower and npm packages get the update?
nmeierpolys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 7 non-unicode emoji included in the picker. When outputting to unicode format, these come through with the :: format instead of the image. This PR filters the set of emoji in the picker when outputting to unicode format so users can only choose ones that will be usable.
Fixes #17