Add len type generic param #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I've been pretty busy recently, I'll review and test this out when I wake up tomorrow. Sorry for the delay, and thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a new base type
StackStringBase[T; Size: static Natural]that has a generic parameter for the string length size.For backwards compatibility purposes,
StackString[N: static Natural]is defined as a type aliastype StackString*[Size: static Natural] = StackStringBase[Natural, Size].There is a compile time check in the constructor functions (like
stackStringOfCap) that gives a compile time error ifTis not large enough to holdSizecharacters. Unfortunately I couldn't find a way get the compiler to do the check in the type itself.