-
Notifications
You must be signed in to change notification settings - Fork 2
Synchronized output support #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OK, I fixed the cursor "dancing" during animation with sync enabled by changing to Console.Write() instead of WriteLine(), but went ahead and hid the cursor anyway, and then the cursor show is a WriteLine(). Animations look so much better without the cursor, but using Ctrl+C does result in the cursor not being re-enabled. With WT at least, simply typing a letter makes it reappear. But I'm a little bit torn about using it because of the effect on other terminals. Depending on which one, it looks like there are a variety of tricks people might use to get it back, but I can imagine it might be an annoying experience. But it's so easy not to use Ctrl+C when the prompt is right in front of you. What do you think? EDIT: Wait, the hide should go in the example, not the library. Then it's much less of an issue.... |
Yes, the cursor dancing behavior is indeed a concern. |
teramako
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! This is a nice feature.
Fixes #15
No more flicker during animation!
For Windows Terminal support, this currently requires a Canary nightly build.
The only issue that I see right now is that the cursor dances a bit (see video). I'm sure it's something simple; I haven't looked into it yet. I'll mark this as draft until that's fixed; but perhaps it can be moot since the cursor flickering has always been an issue: should we just turn off the cursor when animating and turn it back on again after?
Hide: CSI ?25l
Show: CSI ?25h.
EDIT: And I guess we might swap the reverse /t only if Synchronized output is supported...?
EDIT 2: Note this video is the elephant APNG; the elephant GIF still has the transparent eye issue in #24 .
Elephant.no.flicker.mp4