-
Notifications
You must be signed in to change notification settings - Fork 7
Issue 271 support for arbitrary text to top banner #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Issue 271 support for arbitrary text to top banner #272
Conversation
…onment variable. Editing environment variables on runtime with Java is not really supported, and there might be security concerns.
These can be set by Environment variables (via zeppelin-env.sh) or by System Properties (via zeppelin-site.xml). Environment variables always take priority.
…g updating announcement texts that are set via Environment variables due to security concerns
…ent text cannot be reassigned due to it being overridden by an Environment value
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/main/java/com/teragrep/zep_01/rest/ZeppelinRestApi.java
Outdated
Show resolved
Hide resolved
zeppelin-interpreter/src/main/java/com/teragrep/zep_01/conf/ZeppelinConfiguration.java
Outdated
Show resolved
Hide resolved
zeppelin-server/src/test/java/com/teragrep/zep_01/rest/ZeppelinRestApiTest.java
Show resolved
Hide resolved
MoonBow-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing that hits my eye, is the method naming in ZeppelinRestApi, where they are get* and set*
Not sure if those should be changed, so maybe an approval from someone who knows ZEP_01 better would now be helpful
I replaced setAnnouncement with putAnnouncement, so that we can differentiate between the method names based on what kind of HTTP request was received, it might be more clear if these method names appear in stack traces for example. |
Description
closes #271
Adds support for an announcement text to be set and retrieved from server
The announcement text is stored as a configuration value, and can be set in the same way as any other configuration value: via environment variables (Set via zeppelin-env.sh) or via System properties (can be set via API endpoints), prioritizing environment variables.
Includes a new API endpoint /api/announcement, supporting GET and PUT requests. These allow for retrieving or setting the System property for announcement text, respectively.
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality