Skip to content

Conversation

@elliVM
Copy link
Contributor

@elliVM elliVM commented Dec 18, 2025

Description

StreamDBClient implements AutoClosable with a close() method that closes the created JDBC Connection.

Checklists

Testing

Changes effect only objects internal operation no unit testing for non public operation.

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@elliVM elliVM requested a review from Tiihott December 18, 2025 09:33
@elliVM elliVM self-assigned this Dec 18, 2025
@elliVM elliVM force-pushed the streamdbclient-autoclosable branch from 0f9357f to dcda331 Compare January 23, 2026 09:12
@elliVM
Copy link
Contributor Author

elliVM commented Jan 23, 2026

rebased

Copy link
Contributor

@Tiihott Tiihott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and changes look good. LGTM

@elliVM elliVM force-pushed the streamdbclient-autoclosable branch from dcda331 to 1f51ef6 Compare January 30, 2026 12:23
@elliVM
Copy link
Contributor Author

elliVM commented Jan 30, 2026

rebased

@elliVM elliVM requested a review from kortemik January 30, 2026 12:28
@elliVM elliVM added the review Issues or pull requests waiting for a review label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Issues or pull requests waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamDBClient builds a connection but does not provide a way to close it

2 participants