Skip to content

Conversation

@Tiihott
Copy link
Contributor

@Tiihott Tiihott commented Nov 11, 2025

Description

The aim of this pull request is to replace the original logtag column of logfile table with normalized logtag table in StreamDBClient queries.

Blocking: This pull request should be merged and released together with the database schema change that drops logtag column from logfile table.

Includes:

  • Commits from PR Updated jooq auto-generated code with new normalized logtag table for journaldb #210
  • Dropping of logtag column from jooq auto-generated code and journaldb.sql file.
  • Updated indexing in jooq auto-generated code to mirror the REST-01 PR 29 changes.
  • Migration to using the normalized logtag table in StreamDBClient queries.
  • Updated StreamDBClient tests to accommodate the migration to normalized logtag table.

Resolves #234

Checklists

Testing

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@Tiihott Tiihott requested a review from elliVM November 11, 2025 13:17
@Tiihott Tiihott self-assigned this Nov 11, 2025
@Tiihott Tiihott requested a review from elliVM November 13, 2025 09:09
elliVM
elliVM previously approved these changes Nov 13, 2025
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready

@Tiihott
Copy link
Contributor Author

Tiihott commented Jan 14, 2026

Rebased to main

@kortemik
Copy link
Member

please rebase

@Tiihott
Copy link
Contributor Author

Tiihott commented Jan 20, 2026

Rebased to main, ready for review.

@Tiihott Tiihott marked this pull request as ready for review January 20, 2026 07:10
@Tiihott Tiihott requested a review from elliVM January 20, 2026 07:10
@Tiihott Tiihott requested a review from kortemik January 20, 2026 07:20
@Tiihott Tiihott added the review Issues or pull requests waiting for a review label Jan 20, 2026
.innerJoin(JOURNALDB.HOST)
.on((STREAMDB.HOST.NAME).eq(JOURNALDB.HOST.NAME))
.innerJoin(JOURNALDB.LOGTAG)
.on((STREAMDB.STREAM.TAG).eq(JOURNALDB.LOGTAG.LOGTAG_))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not use id based join. please change rest-03 code first to include logtag_id in addition to the string and use the logtag_id in the join statement

@Tiihott Tiihott removed the review Issues or pull requests waiting for a review label Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update logfile table reads to use normalized logtag table

3 participants