-
Notifications
You must be signed in to change notification settings - Fork 9
Normalized logtag table for StreamDBClient queries #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
elliVM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready
|
Rebased to main |
|
please rebase |
…lized logtag table. REBASE
…ullToSliceTableInvalidIndexTest() to StreamDBClient tests. REBASE
|
Rebased to main, ready for review. |
| .innerJoin(JOURNALDB.HOST) | ||
| .on((STREAMDB.HOST.NAME).eq(JOURNALDB.HOST.NAME)) | ||
| .innerJoin(JOURNALDB.LOGTAG) | ||
| .on((STREAMDB.STREAM.TAG).eq(JOURNALDB.LOGTAG.LOGTAG_)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not use id based join. please change rest-03 code first to include logtag_id in addition to the string and use the logtag_id in the join statement
Description
The aim of this pull request is to replace the original logtag column of logfile table with normalized logtag table in StreamDBClient queries.
Blocking: This pull request should be merged and released together with the database schema change that drops logtag column from logfile table.
Includes:
Resolves #234
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality