-
Notifications
You must be signed in to change notification settings - Fork 9
Apply jooq boolean conditions when condition regex is always true or false #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tiihott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wildcard handling needs clarification. If the .replace('*', '%') is made obsolete by the new changes then it should be removed.
Otherwise looks good.
src/main/java/com/teragrep/pth_06/planner/walker/conditions/HostCondition.java
Show resolved
Hide resolved
src/main/java/com/teragrep/pth_06/planner/walker/conditions/HostCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth_06/planner/walker/conditions/IndexCondition.java
Show resolved
Hide resolved
src/main/java/com/teragrep/pth_06/planner/walker/conditions/IndexCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth_06/planner/walker/conditions/SourceTypeCondition.java
Show resolved
Hide resolved
src/main/java/com/teragrep/pth_06/planner/walker/conditions/SourceTypeCondition.java
Outdated
Show resolved
Hide resolved
Tiihott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2f97d5b to
23d4348
Compare
|
rebased |
23d4348 to
4fae7b0
Compare
|
rebased |
Tiihott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… in conditions that support wildcards
4fae7b0 to
677b7a8
Compare
|
rebased |
Description
When a condition has just a regex wildcard
*without any partial values we know it will always be true. We can then replace it with JOOQ provided dummy boolean values letting JOOQ to prune these conditions before SQL execution.Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality