Skip to content

Conversation

@elliVM
Copy link
Contributor

@elliVM elliVM commented Aug 27, 2025

Description

When a condition has just a regex wildcard * without any partial values we know it will always be true. We can then replace it with JOOQ provided dummy boolean values letting JOOQ to prune these conditions before SQL execution.

Checklists

Testing

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@elliVM elliVM self-assigned this Aug 27, 2025
@elliVM elliVM added the enhancement New feature or request label Aug 27, 2025
@elliVM elliVM requested a review from Tiihott August 27, 2025 10:10
@elliVM elliVM linked an issue Aug 27, 2025 that may be closed by this pull request
Copy link
Contributor

@Tiihott Tiihott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard handling needs clarification. If the .replace('*', '%') is made obsolete by the new changes then it should be removed.
Otherwise looks good.

@elliVM elliVM requested a review from Tiihott September 1, 2025 08:11
Copy link
Contributor

@Tiihott Tiihott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliVM elliVM requested a review from kortemik September 3, 2025 08:10
@elliVM
Copy link
Contributor Author

elliVM commented Nov 19, 2025

rebased

@elliVM elliVM added the review Issues or pull requests waiting for a review label Nov 19, 2025
@elliVM
Copy link
Contributor Author

elliVM commented Dec 29, 2025

rebased

@elliVM elliVM requested a review from Tiihott December 29, 2025 06:15
@elliVM elliVM removed the review Issues or pull requests waiting for a review label Dec 29, 2025
Copy link
Contributor

@Tiihott Tiihott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliVM elliVM added the review Issues or pull requests waiting for a review label Jan 19, 2026
@elliVM
Copy link
Contributor Author

elliVM commented Jan 23, 2026

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request review Issues or pull requests waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace match any regex with always true condition

2 participants