Fix KafkaBatchSliceCollection dereferencing a pointer that might be null #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51-code
approved these changes
Feb 17, 2025
Member
|
this is likely a improper course of action. null offsets are provided by the spark framework and have specific meaning. more over the class itself is a mutable one so returning this will return a mutated state and not an empty list like the comment states. please investigate further. |
kortemik
requested changes
Apr 24, 2025
Member
kortemik
left a comment
kortemik
left a comment
There was a problem hiding this comment.
please check previous comment
Contributor
Author
|
we have created an issue to investigate this further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an empty collection if offsets are null in KafkaBatchSliceCollection Class