Element condition refactoring and exception message fix #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemhu
reviewed
Dec 13, 2024
src/test/java/com/teragrep/pth_06/planner/walker/conditions/StreamingConditionTest.java
Outdated
Show resolved
Hide resolved
eemhu
reviewed
Dec 13, 2024
src/test/java/com/teragrep/pth_06/planner/walker/conditions/StreamingConditionTest.java
Outdated
Show resolved
Hide resolved
elliVM
force-pushed
the
element-condition-refactoring
branch
from
f1627ab to
bce62f0
Compare
Contributor
Author
|
rebased |
eemhu
reviewed
Dec 16, 2024
src/main/java/com/teragrep/pth_06/planner/walker/conditions/NonStreamingCondition.java
Outdated
Show resolved
Hide resolved
eemhu
reviewed
Dec 16, 2024
src/test/java/com/teragrep/pth_06/planner/walker/conditions/NonStreamingConditionTest.java
Outdated
Show resolved
Hide resolved
…est resulting conditions of accepted values NonStreamingCondition
eemhu
approved these changes
Dec 17, 2024
Member
|
There are two changes in the same pr and therefore review process takes time. Please separate the exception fix and pr it first as it's a very simple change. |
kortemik
requested changes
Apr 11, 2025
|
|
||
| import java.util.Objects; | ||
|
|
||
| public final class StreamingCondition implements QueryCondition { |
Member
There was a problem hiding this comment.
class name is misleading. all queries are micro-batch-streaming queries. this most likely refers streamdb query which is a non-time-range query where it's relevant pair journaldb query has time bounds. please refactor.
| private final String operation; | ||
| private final ConditionConfig config; | ||
|
|
||
| public NonStreamingCondition(String tag, String value, String operation, ConditionConfig config) { |
Member
There was a problem hiding this comment.
see comment on StreamingCondition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #120 and #123
Clears up
ElementConditionlogic by splitting streaming and non streaming conditions into own classes.Fixes issue where an error message was thrown if a recognized element name was encountered in a streaming query like
<earliest>. These elements now result to aDSL.noConditionthat functions as a "where is true" value in a query as a pass through condition, and will not have effect the query.ConditionWalkeris refactored not to negate aDSL.noConditionas it would result into a condition that is never true i.e. "where not true".Exception is thrown if a unknown element name is encountered like
<random>.Refactor
IndexStatementto not use a base condition from constructor as this was not needed.