Issue 30: Add Rule/Condition objects to allow specifying eventType based on multiple factors #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; Add ContainerRule & test; Add DefaultCondition; Make EnvironmentSource map immutable; change NLFPlugin to use Rules; change error message asserts to match new logic; add Rule interface; add RuleStub; add SyslogProcessNameCondition; add SyslogRule & test; remove processName validation from SyslogType; add TypeCondition; add TypeSuffixCondition
MoonBow-1
requested changes
Mar 10, 2025
Contributor
MoonBow-1
left a comment
MoonBow-1
left a comment
There was a problem hiding this comment.
I was a bit confused about the Predicate generic, but figured their use of the .test method.
A description of the PR would've been nice to have, since there is only an issue, which contains a request for a feature.
src/main/java/com/teragrep/nlf_01/condition/SyslogProcessNameCondition.java
Show resolved
Hide resolved
MoonBow-1
reviewed
Mar 10, 2025
Contributor
MoonBow-1
left a comment
MoonBow-1
left a comment
There was a problem hiding this comment.
A question about the behavior of the test(ParsedEvent parsedEvent) method
src/main/java/com/teragrep/nlf_01/condition/SyslogProcessNameCondition.java
Outdated
Show resolved
Hide resolved
change SyslogProcessNameCondition match checks to final booleans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30