-
Notifications
You must be signed in to change notification settings - Fork 2
3 filesystem and basic connectivity #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Laukkala
wants to merge
242
commits into
teragrep:main
Choose a base branch
from
Laukkala:3_Filesystem_implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndpoints to provide their responses with Json format instead of plain text
… as a string instead of a sringified array
Added a test case Added a specific Exception message when trying to move a directory into the same path where it already is.
…o 3_Filesystem_implementation # Conflicts: # src/test/java/com/teragrep/nbs_01/endpoints/MoveDirectoryEndPointTest.java
eemhu
reviewed
May 22, 2025
eemhu
reviewed
May 22, 2025
eemhu
reviewed
May 22, 2025
…t be coupled with any specific format. Now LocalFilesystemStorage is the one that decides in which format the Notebooks are serailzied in.
…ir proper objects. Request body contains sourceIdentifiers, sourceParagraphIds, titles and texts, Request path is parsed to retrieve targetIdentifiers and targetParagraphIds. Previously this parsing was done in BasicHTTPRequest, but that introduces coupling with JSON format and Paths. You might want to use other formats, so the parsing was moved to separate objects behind Interfaces so that they can be changed without having to rewrite BasicHTTPRequest. Removed Request.Type enum which was used to split paragraphIds from request paths, and replaced it with a HTTPRequestPath and HTTPParagraphRequestPath objects.
…istent. "name" is still supported when reading from legacy files, where it was still in use.
…e properly deleted between tests.
…ractNotebookServerTest
…oint, as UpdateParagraphEndpoint and CreateNotebookEndpoint were expecting different kinds of handling for missing "title" parameter. Now they handle these cases on their own. Removed some unused Exceptions based on code analysis
This was referenced Jan 15, 2026
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First version of NotebookServer
Check NBS_01 page on internal wiki for goals and design documentation on NBS_01
Below is a list of the most important Interfaces and objects of the component
Server & Servlets
HTTP communication
Endpoints
Repository
Storage
Checklists
Checklists blank as this is the initial version, may still see major changes
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality