Capture Group endpoints refactored separately. #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nefarious46
commented
Nov 26, 2025
Nefarious46
commented
- Endpoints for inserting standalone Capture Groups
- Replaces PR Capture Group endpoints refactored separately #169
- Rebased with spotless and flow_id in group.
…and flow_id in group
kortemik
requested changes
Nov 27, 2025
| public class CaptureGroup { | ||
|
|
||
| public enum group_type { | ||
| public enum groupType { |
Member
There was a problem hiding this comment.
enums are like classes, their name must start with capital and values must be capitalized
Contributor
Author
There was a problem hiding this comment.
Enums fixed in this one but there will be separate PR where all enums are corrected as such to avoid mismatches with database insertions.
|
|
||
| @RestController | ||
| @RequestMapping(path = "capture") | ||
| @RequestMapping(path = "capture/group") |
Member
There was a problem hiding this comment.
let's paths to
/v2/captures/group/1
/v2/captures/capture/1
| // GET ALL | ||
| @RequestMapping( | ||
| path = "/group", | ||
| path = "/{id}", |
Member
There was a problem hiding this comment.
see previous api path changes for refactoring this
| } | ||
|
|
||
| @RequestMapping( | ||
| path = "/{id}", |
…ture group entity
Contributor
Author
|
Paths corrected as suggested. |
Contributor
Author
|
Renamed CaptureGroupController to CaptureGroupsController since it is handling group specifics and not singular group. CaptureGroupController will be included in the linking Controller. #197 |
kortemik
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.