Capture group capture linkage endpoint refactor #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nefarious46
commented
Jun 2, 2025
| <cfe_18.capture_def_group id="4" capture_def_group_name="capturegroup4" capture_type="cfe"/> | ||
| <cfe_18.capture_def_group id="5" capture_def_group_name="capturegroup5" capture_type="cfe"/> | ||
| <cfe_18.capture_def_group id="6" capture_def_group_name="capturegroup6" capture_type="cfe"/> | ||
| <cfe_18.capture_def_group id="22" capture_def_group_name="group1" capture_type="cfe"/> |
Contributor
Author
There was a problem hiding this comment.
New feature does not create capture group anymore alongside linking so test will not work with this testdata. For linking purposes, existing group needs to be used.
Nefarious46
commented
Jun 2, 2025
Contributor
Author
There was a problem hiding this comment.
Does have exception signature still. Was not in the scope of this PR so will be removed when linkage feature gets reworked.
eemhu
reviewed
Jun 6, 2025
|
|
||
| @Mapper | ||
| public interface CaptureGroupMapper { | ||
| public interface CaptureGroup_Mapper { |
Collaborator
There was a problem hiding this comment.
underscore should be removed
eemhu
reviewed
Jun 6, 2025
| @RestController | ||
| @RequestMapping(path = "group/captures") | ||
| @SecurityRequirement(name = "api") | ||
| public class CaptureGroup_Controller { |
eemhu
reviewed
Jun 6, 2025
| if (cause instanceof SQLException) { | ||
| LOGGER.error((cause).getMessage()); | ||
| int error = ((SQLException) cause).getErrorCode(); | ||
| String state = error + "-" + ((SQLException) cause).getSQLState(); |
Collaborator
There was a problem hiding this comment.
use error.equals(...) && state.equals(...) instead of string concatenation
Contributor
Author
|
This should be checked after PR #169 |
Nefarious46
force-pushed
the
CaptureGroupCaptureLinkageEndpointRefactor
branch
from
b6659ba to
52f432c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info on PR #155