Flow Storage endpoints refactored separately #173

Nefarious46 · 2025-05-27T08:09:38Z

Void on delete mapper
No exceptions signatures in unit tests
409 conflict is now returned when in use and 404 when record not found
Updated apidoc
Separated FlowController to it's own controller
TestData is inserted before unit tests

More info on PR #155

eemhu · 2025-06-06T09:04:31Z

src/main/java/com/teragrep/cfe18/handlers/FlowStorageController.java

+                    content = @Content),
+            @ApiResponse(responseCode = "404", description = "Flow or Storage does not exist",
+                    content = @Content),
+            @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content)})


500 necessary?

500 s swapped to 400 s

eemhu · 2025-06-06T09:08:09Z

src/main/java/com/teragrep/cfe18/handlers/FlowStorageController.java

+            @ApiResponse(responseCode = "404", description = "Flow storage does not exist",
+                    content = @Content),
+            @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content)})
+    public ResponseEntity<String> delete(@PathVariable("flowId") int flowId, @PathVariable("id") int id) {


is the id storageId here or something different?

it is indeed storage_id, will rectify for clarity.

This endpoint specifically removes storage from being specific to a flow.

eemhu · 2025-06-06T09:26:38Z

src/main/java/com/teragrep/cfe18/handlers/StorageController.java

+                            schema = @Schema(implementation = Storage.class))}),
+            @ApiResponse(responseCode = "400", description = "Storage name already exists",
                    content = @Content),
            @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content)


eemhu · 2025-06-06T09:27:59Z

src/main/java/com/teragrep/cfe18/handlers/StorageController.java

                    content = {@Content(mediaType = "application/json",
                            schema = @Schema(implementation = CaptureStorage.class))}),
-            @ApiResponse(responseCode = "400", description = "Capture storage does not exist with the given ID",
+            @ApiResponse(responseCode = "404", description = "Flow storage does not exist",


capture storage or flow storage?

Yes Flow Storage, Capture Storage requires Flow Storage to exist before assigning Storage to a Capture. This works as a middleman to specify which Flow is Storage being used in.

eemhu · 2025-06-06T09:49:51Z

src/main/java/com/teragrep/cfe18/handlers/StorageController.java

-    })
-    public ResponseEntity<String> linkStorageToCapture(@RequestBody CaptureStorage newCaptureStorage) {
-        LOGGER.info("About to insert <[{}]>",newCaptureStorage);
+            @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content)})


eemhu · 2025-06-06T10:13:19Z

src/main/resources/com/teragrep/cfe18/StorageMapper.xml


+    <!-- insert         ( capture_id INT, storage_id INT ) -->
+    <select id="createCaptureStorage" resultMap="insertedIDCapture" statementType="CALLABLE">
+        {CALL flow.add_storage_for_capture(#{param1},#{param2})}


should this be changed add->insert?

Not in the scope of this PR. Capture Storage feature comes in separate PR.

eemhu · 2025-06-06T10:58:47Z

src/test/java/com/teragrep/cfe18/controllerTests/FlowStorageControllerTest.java

+        // Assertions
+        assertEquals(expectedFlow, actualFlow);
+        assertThat(
+                httpResponseStorage.getStatusLine().getStatusCode(),


-> assertEquals

swapped all Thats to Equals

eemhu · 2025-06-06T10:59:35Z

src/test/java/com/teragrep/cfe18/controllerTests/FlowStorageControllerTest.java

+
+        String responseStringGet = Assertions.assertDoesNotThrow(() -> EntityUtils.toString(entityGet, "UTF-8"));
+
+        String expectedJson = new Gson().toJson(expected);


could use gson field variable?

… 173

Nefarious46 requested a review from kortemik May 27, 2025 08:09

Nefarious46 self-assigned this May 27, 2025

Nefarious46 added enhancement New feature or request review labels May 27, 2025

eemhu reviewed Jun 6, 2025

View reviewed changes

Nefarious46 added 3 commits June 25, 2025 10:25

Flow Storage endpoints refactored separately

8579956

reverted CaptureStorage portion from Storage mapper

a9eadad

Reverted Storage endpoints to older version and made changes for PR #…

e8226bd

… 173

Nefarious46 force-pushed the FlowStorageEndpointRefactor branch from 3d091ee to e8226bd Compare June 25, 2025 11:43

q22u removed the review label Aug 22, 2025


		String responseStringGet = Assertions.assertDoesNotThrow(() -> EntityUtils.toString(entityGet, "UTF-8"));

		String expectedJson = new Gson().toJson(expected);

Flow Storage endpoints refactored separately #173

Are you sure you want to change the base?

Flow Storage endpoints refactored separately #173

Uh oh!

Conversation

Nefarious46 commented May 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants