File Processing Type endpoints refactored separately #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemhu
reviewed
Jun 5, 2025
| schema = @Schema(implementation = FileProcessing.class))}), | ||
| @ApiResponse(responseCode = "400", description = "Inputvalue must be regex or newline", | ||
| content = @Content), | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content) |
Contributor
Author
There was a problem hiding this comment.
changed 500 to 400.
eemhu
reviewed
Jun 5, 2025
| @ApiResponse(responseCode = "400", description = "File processing type does not exist with the given id", | ||
| @ApiResponse(responseCode = "404", description = "File processing type does not exist", | ||
| content = @Content), | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content) |
Contributor
Author
There was a problem hiding this comment.
changed 500 to 400.
eemhu
reviewed
Jun 5, 2025
| content = @Content), | ||
| @ApiResponse(responseCode = "404", description = "File processing type does not exist", | ||
| content = @Content), | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content) |
Contributor
Author
There was a problem hiding this comment.
changed 500 to 400.
eemhu
reviewed
Jun 5, 2025
| String actual = Assertions.assertDoesNotThrow(() -> responseAsJson.get("message").toString()); | ||
|
|
||
| // Assertions | ||
| assertEquals(expected, actual); |
Collaborator
There was a problem hiding this comment.
should this also assert the response code?
eemhu
reviewed
Jun 5, 2025
| String responseStringGet = Assertions.assertDoesNotThrow(() -> EntityUtils.toString(entityGet, "UTF-8")); | ||
|
|
||
| assertEquals(json, responseStringGet); | ||
| assertThat(responseGet.getStatusLine().getStatusCode(), equalTo(HttpStatus.SC_OK)); |
eemhu
reviewed
Jun 5, 2025
| @Test | ||
| @Order(2) | ||
| public void testGetFileProcessingTypeByName() throws Exception { | ||
| public void testGetFileProcessingTypeById() { |
Collaborator
There was a problem hiding this comment.
should perhaps add invalid id test?
Contributor
Author
There was a problem hiding this comment.
added testGetFileProcessingTypeByInvalidId to check if invalid ID is used to fetch record.
eemhu
reviewed
Jun 5, 2025
| @Order(3) | ||
| public void testGetAllFileProcessingTypesTypes() throws Exception { | ||
| public void testGetAllFileProcessingTypes() { | ||
| GsonBuilder gson2 = new GsonBuilder().serializeNulls(); |
Collaborator
There was a problem hiding this comment.
no file processing types case?
Contributor
Author
There was a problem hiding this comment.
added testGetAll at the start to check this behaviour. Funny thing to notice here, testGetAllFileProcessingTypesNoResults name did not work since it was executed last even tho order was 1 and test was added first thing in the unit test class.
Nefarious46
force-pushed
the
FileProcessingTypeEndpointRefactor
branch
from
5e7efc5 to
0fde527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info on PR #155
Currently RESTful path is
file/capture/metabut should maybe differ a bit so that there is no confusion withcapture/metapath.Maybe something like
capture/processingorfile/capture/processing. Thoughts? @kortemik