Sink endpoint refactor #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eemhu merged 13 commits into teragrep:main from Nefarious46:SinkEndpointRefactor

Jun 10, 2025

Contributor

Nefarious46 commented May 20, 2025 •

edited

Loading

Entity variables into right format
Controllers and mappers in correct order of CREATE, GET, GET ALL, DELETE
No more postfixes
Touched a lot of different unit tests aswell since they require insertion of Sink

Fixes issue #175

More info on PR #155

Nefarious46 requested a review from kortemik

May 20, 2025 09:19

Nefarious46 self-assigned this

Nefarious46 added the enhancement label

Nefarious46 added the review label

kortemik reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Outdated Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Show resolved Hide resolved

kortemik requested changes

View reviewed changes

Member

kortemik left a comment

minor changes needed, please fix and ask @eemhu to merge after review of the fixes

src/main/java/com/teragrep/cfe18/handlers/entities/Sink.java Show resolved Hide resolved

src/main/resources/db/migration/R__Procedure_Select_All_Sinks.sql Outdated Show resolved Hide resolved

src/main/resources/db/migration/R__Procedure_Select_Sink.sql Outdated Show resolved Hide resolved

src/main/resources/db/migration/R__Procedure_create_sink.sql Outdated Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/java/com/teragrep/cfe18/handlers/SinkController.java Outdated Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/resources/com/teragrep/cfe18/SinkMapper.xml Outdated Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/main/resources/db/migration/R__Procedure_create_sink.sql Outdated Show resolved Hide resolved

eemhu reviewed

View reviewed changes

src/test/java/com/teragrep/cfe18/controllerTests/SinkControllerTest.java Show resolved Hide resolved

Nefarious46 added 9 commits

June 3, 2025 13:53


          Sink endpoints refactored separately

1ee983d


          Parsin to Parsing

722ed34


          Removed unused import org.omg

a83f1b3


          Removed extraneous joins and renamed input variables

b924a83


          Wrong id was returned on get all

257d4d5


          Assert testdata

20e09dd


          Apidoc and response to be more accurate


          SinkMapper parameters changed to be correct

122f840


          ID was wrong on flow_id return with simple select

f42fff9

Nefarious46 force-pushed the SinkEndpointRefactor branch from 2812ea5 to f42fff9 Compare

June 3, 2025 11:29

Nefarious46 added 4 commits

June 3, 2025 14:32


          Comments added for magic numbers with SQL state codes


          Indentation fixes

269efe4


          apidoc updates

6cf34c8


          Reverted app.props

5eb043b

Nefarious46 requested a review from kortemik

June 3, 2025 12:52

Nefarious46 requested a review from eemhu

June 3, 2025 12:52

eemhu approved these changes

View reviewed changes

kortemik approved these changes

View reviewed changes

eemhu merged commit 5001da9 into teragrep:main

q22u removed the review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels