Capture side endpoint refactored separately #158
Conversation
| content = @Content), | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content) | ||
| }) | ||
| public ResponseEntity<?> getRelp(@PathVariable("id") int id, @RequestParam(required = false) Integer version) { |
There was a problem hiding this comment.
why suffix Relp? is get not enough?
There was a problem hiding this comment.
Was accidentally left behind. Corrected.
| content = {@Content(mediaType = "application/json", | ||
| schema = @Schema(implementation = CaptureRelp.class))}), | ||
| }) | ||
| public List<CaptureRelp> getAllRelp(@RequestParam(required = false) Integer version) { |
There was a problem hiding this comment.
why suffix Relp? is get not enough?
There was a problem hiding this comment.
same as get endpoint
| */ | ||
| USE cfe_18; | ||
| DELIMITER // | ||
| CREATE OR REPLACE PROCEDURE select_all_cfe_captures(tx_id INT) |
There was a problem hiding this comment.
please create an issue about renaming cfe -> file on the sql and mapper resultsets
| @TestMethodOrder(MethodOrderer.OrderAnnotation.class) | ||
| @ExtendWith(MigrateDatabaseExtension.class) | ||
| public class CaptureControllerTest extends TestSpringBootInformation { | ||
| class CaptureFileControllerTest extends TestSpringBootInformation { |
src/test/java/com/teragrep/cfe18/controllerTests/CaptureFileControllerTest.java
Show resolved
Hide resolved
| @Order(5) | ||
| public void testgetAllCaptures() throws Exception { | ||
| @Order(3) | ||
| public void testgetAllCfeCaptures() throws Exception { |
| // Entity response string | ||
| String response2 = EntityUtils.toString(entity2); | ||
|
|
||
| // Parsin respponse as JSONObject |
src/test/java/com/teragrep/cfe18/controllerTests/CaptureRelpControllerTest.java
Show resolved
Hide resolved
| request1.setHeader("Authorization", "Bearer " + token); | ||
|
|
||
| // Get the response from endpoint | ||
| HttpClientBuilder.create().build().execute(request1); |
| stmnt.execute(); | ||
| }); | ||
| Assertions.assertEquals("42000", state.getSQLState()); | ||
| Assertions.assertEquals("45000", state.getSQLState()); |
There was a problem hiding this comment.
why expected sqls state code changes?
There was a problem hiding this comment.
Previously had 42000 in the custom error handling. That was wrong since 42000 is reserved for MariaDB own specific errors.
For customized errors, the recommended SQLSTATE is '45000'.
Source : https://mariadb.com/kb/en/signal/
2 participants
Pull request #155 has more in-detail comments about changes.