Skip to content

Conversation

@MoonBow-1
Copy link
Contributor

@MoonBow-1 MoonBow-1 commented Mar 28, 2025

The dependency doesn't seems to be used in anyway, so it should be removed to to limit the possible vulnerability vectors

  • Also adds the LICENSE header to the pom.xml

CI fails, because #15 hasn't been merged yet, causing Java 17 to not like the mocking tests

@MoonBow-1 MoonBow-1 requested a review from eemhu March 28, 2025 08:12
@MoonBow-1 MoonBow-1 self-assigned this Mar 28, 2025
Copy link
Contributor

@eemhu eemhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if it is not needed, maybe @kortemik can confirm?

@MoonBow-1 MoonBow-1 requested a review from kortemik March 31, 2025 07:02
@kortemik kortemik merged commit a529c63 into teragrep:master Mar 31, 2025
1 check passed
@kortemik
Copy link
Member

looks good to me too, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants