Skip to content

fix: reject zero-slot CIRCULAR_BUFFER outputs #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sakura-501 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reject zero-slot CIRCULAR_BUFFER outputs #3517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorflow/lite/micro/kernels/circular_buffer_common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ TfLiteStatus CircularBufferPrepare(TfLiteContext* context, TfLiteNode* node) {
TF_LITE_ENSURE_EQ(context, 1, input->dims->data[1]);
TF_LITE_ENSURE_EQ(context, input->dims->data[2], output->dims->data[2]);
TF_LITE_ENSURE_EQ(context, output->dims->data[3], input->dims->data[3]);
TF_LITE_ENSURE(context, output->dims->data[1] > 0);

TF_LITE_ENSURE_TYPES_EQ(context, input->type, output->type);

Expand Down
38 changes: 38 additions & 0 deletions tensorflow/lite/micro/kernels/circular_buffer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,42 @@ TEST(CircularBufferTest, OutputTensorLength5) {
}
}

TEST(CircularBufferTest, RejectsZeroNumSlots) {
constexpr int depth = 4;
int8_t input_data[depth];
int8_t output_data[1];

memset(output_data, 0, sizeof(output_data));
int input_dims[] = {4, 1, 1, 1, depth};
int output_dims[] = {4, 1, 0, 1, depth};
TfLiteIntArray* input_tensor_dims =
tflite::testing::IntArrayFromInts(input_dims);
TfLiteIntArray* output_tensor_dims =
tflite::testing::IntArrayFromInts(output_dims);

constexpr int inputs_size = 2;
constexpr int outputs_size = 1;
constexpr int tensors_size = inputs_size + outputs_size;
TfLiteTensor tensors[tensors_size] = {
tflite::testing::CreateQuantizedTensor(input_data, input_tensor_dims, 1,
0),
tflite::testing::CreateQuantizedTensor(output_data, output_tensor_dims, 1,
0),
};

int inputs_array_data[] = {1, 0};
TfLiteIntArray* inputs_array =
tflite::testing::IntArrayFromInts(inputs_array_data);
int outputs_array_data[] = {1, 1};
TfLiteIntArray* outputs_array =
tflite::testing::IntArrayFromInts(outputs_array_data);

const TFLMRegistration* registration = tflite::Register_CIRCULAR_BUFFER();
tflite::micro::KernelRunner runner = tflite::micro::KernelRunner(
*registration, tensors, tensors_size, inputs_array, outputs_array,
/*builtin_data=*/nullptr);

EXPECT_EQ(kTfLiteError, runner.InitAndPrepare());
}

TF_LITE_MICRO_TESTS_MAIN
Loading