Skip to content

fix: prevent EXP negative dimension size_t cast out of bounds access #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sakura-501 wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

fix: prevent EXP negative dimension size_t cast out of bounds access #3516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorflow/lite/micro/kernels/exp.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ TfLiteStatus ExpEval(TfLiteContext* context, TfLiteNode* node) {
tflite::micro::GetEvalOutput(context, node, kOutputTensor);
int flat_size = MatchingFlatSize(tflite::micro::GetTensorShape(input),
tflite::micro::GetTensorShape(output));
TF_LITE_ENSURE(context, flat_size >= 0);

if (input->type == kTfLiteFloat32) {
reference_ops::Exp(tflite::micro::GetTensorData<float>(input),
Expand Down
28 changes: 28 additions & 0 deletions tensorflow/lite/micro/kernels/exp_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,32 @@ TEST(ExpTest, SingleDim) {
tflite::testing::TestExp(input_dims, input_values, golden, output_data);
}

TEST(ExpTest, NegativeDimensionShallFail) {
int dims_data[] = {1, -1};
TfLiteIntArray* dims = tflite::testing::IntArrayFromInts(dims_data);
float input_data[1] = {0.0f};
float output_data[1] = {0.0f};

TfLiteTensor tensors[2] = {
tflite::testing::CreateTensor(input_data, dims),
tflite::testing::CreateTensor(output_data, dims),
};

int inputs_array_data[] = {1, 0};
TfLiteIntArray* inputs_array =
tflite::testing::IntArrayFromInts(inputs_array_data);
int outputs_array_data[] = {1, 1};
TfLiteIntArray* outputs_array =
tflite::testing::IntArrayFromInts(outputs_array_data);

const TFLMRegistration registration = tflite::Register_EXP();
tflite::micro::KernelRunner runner(registration, tensors,
/*tensors_size=*/2, inputs_array,
outputs_array,
/*builtin_data=*/nullptr);

EXPECT_EQ(kTfLiteOk, runner.InitAndPrepare());
EXPECT_EQ(kTfLiteError, runner.Invoke());
}

TF_LITE_MICRO_TESTS_MAIN
Loading