[codex] add checkpoint replay and shared primal ownership#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckpointRecipe,ReplayResult, andTape::record_checkpointed_opTrackedValuehandles so retained ops no longer requireV: CloneRoot Cause
tidupreviously assumed reverse execution always used permanently materialized rules. The checkpoint replay refactor fixed that for pullback/HVP, but the first cut duplicated retained primals between the tape andTrackedValue, which introduced unnecessaryV: Clonerequirements on retained operations.Impact
Validation
cargo fmt --all --checkcargo clippy --workspacecargo nextest run --release --workspace --no-fail-fastcargo test --doc --release --workspacecargo llvm-cov nextest --workspace --release --json --output-path coverage.jsonpython3 scripts/check-coverage.py coverage.jsoncargo doc --workspace --no-depspython3 scripts/check-docs-site.pybash scripts/build_docs_site.shGenerated with Codex.