feat: deferred leaf tangent injection for HVP#7
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the "tangents baked into rules at construction time" HVP workflow with a fully deferred model. Leaf tangent directions v are now passed as a HashMap<NodeId, V::Tangent> to Tape::hvp() at call time. Changes: - chainrules-core: add forward_tangents() method and input_tangents closure param to pullback_with_tangents() on ReverseRule trait - tidu: two-phase hvp_from algorithm (forward tangent propagation + reverse pass with tangent provider) - Tape::hvp() takes leaf_tangents HashMap instead of relying on leaf_with_tangent() - Add edge-case tests for empty/partial tangent maps Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6
forward_tangents()method andinput_tangentsclosure parameter topullback_with_tangents()onReverseRuletrait (chainrules-rs branch)hvp_fromalgorithm — forward tangent propagation then reverse pass with tangent providerTape::hvp()now takesleaf_tangents: &HashMap<NodeId, V::Tangent>instead of relying onleaf_with_tangent()saved_dxfields)Breaking Changes
Tape::hvpsignature changed: newleaf_tangentsparameterReverseRule::pullback_with_tangentsgainsinput_tangentsclosure parameterdeferred-hvp-tangentsbranchTest plan
cargo nextest run --release)cargo test --doc --release)type_complexitywarning)🤖 Generated with Claude Code