feat: shape-agnostic graph with DimExpr (#651)#653
Merged
Conversation
- Extract inline tests from dim_expr.rs to tests/dim_expr_tests.rs - Add # Panics documentation to DimExpr::eval - Document const_dim limitation in linalg AD rules - Add graph reuse test for reshape_sym with different input shapes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add tests for Sub, Div, usize-lhs operators, and min/max methods to bring sym_dim.rs coverage above 80%. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec<usize>shape fields inStdTensorOptoVec<DimExpr>, enabling graph reuse across varying tensor sizes (e.g., bond dimension changes in DMRG/ALS)DimExprtype witheval,remap,input_shape, and arithmetic helpersSymDimuser-facing API with operator overloading (sym_size,reshape_sym)TracedTensor.shapetoTracedTensor.rank(rank-only tracking at trace time)DimExpr::remap_allfor backward opsresolve_tensor_shape_exprsKnown Limitations
const_dim) require concreteDimExpr::Constvalues; symbolicInputDimwill panic (documented)shape_hintretained inTracedTensorfor broadcast/linalg trace-time shape computationTest plan
cargo test --workspace --release)DimExprunit tests (eval, remap, input_shape, hash/eq)SymDimintegration tests (sym_size, reshape_sym, mixed arithmetic)cargo fmt --all --checkcargo doc --workspace --no-depsCloses #651
🤖 Generated with Claude Code