fix: try multiple library names when loading HDF5 on Linux#20
Merged
Conversation
On Debian/Ubuntu, the HDF5 shared library is named `libhdf5_serial.so` rather than `libhdf5.so`. The previous code only tried `libhdf5.so`, causing dlopen to fail on these distributions. Now tries multiple candidate names in order: - Linux: `libhdf5.so`, `libhdf5_serial.so` - macOS: `/opt/homebrew/lib/libhdf5.dylib`, `/usr/local/lib/libhdf5.dylib`, `libhdf5.dylib` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libhdf5_serial.so, notlibhdf5.solibhdf5.so, causingdlopento fail on these distributionsChanges
init()to use adefault_library_candidates()function returning a list of names to trylibhdf5.so,libhdf5_serial.so/opt/homebrew/lib/libhdf5.dylib,/usr/local/lib/libhdf5.dylib,libhdf5.dylibContext
This fixes a failure in
tensor4all-rsCI wherecargo test --workspacetriggers feature unification, enablingruntime-loading(dlopen path) instead of compile-time linking. On Ubuntu CI runners,libhdf5.sodoesn't exist — onlylibhdf5_serial.so.🤖 Generated with Claude Code