Skip to content

[codex] Pin GitHub fallback tensor4all-rs commit#26

Merged
shinaoka merged 1 commit intomainfrom
feat/pin-github-fallback
Apr 6, 2026
Merged

[codex] Pin GitHub fallback tensor4all-rs commit#26
shinaoka merged 1 commit intomainfrom
feat/pin-github-fallback

Conversation

@shinaoka
Copy link
Copy Markdown
Member

@shinaoka shinaoka commented Apr 6, 2026

Summary

  • pin the GitHub fallback clone in deps/build.jl to a fixed tensor4all-rs commit
  • keep TENSOR4ALL_RS_PATH and sibling ../tensor4all-rs resolution unchanged
  • add a regression test that guards the fallback clone behavior and document it in the README

Why

The build script was reproducible when a local Rust checkout was present, but the GitHub fallback path tracked main. That made fallback builds time-dependent and harder to reproduce.

Validation

  • julia --startup-file=no --project=/home/shinaoka/tensor4all/Tensor4all.jl -e 'using Test; include("/home/shinaoka/tensor4all/Tensor4all.jl/test/test_build_script.jl")'
  • T4A_SKIP_HDF5_TESTS=1 julia --startup-file=no --project=/home/shinaoka/tensor4all/Tensor4all.jl /home/shinaoka/tensor4all/Tensor4all.jl/test/runtests.jl

@shinaoka shinaoka marked this pull request as ready for review April 6, 2026 08:52
@shinaoka shinaoka merged commit 1de1c76 into main Apr 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant