[codex] Fix ComplexF64 SimpleTT site tensor regression#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supersedes the conflict-heavy part of #22 with a clean branch from current
main.Changes:
t4a_simplett_c64_site_tensorbuffer-length handling in the Julia C wrapper so it passes the number of doubles expected by the Rust C APItest/test_conversions.jlcoverage forSimpleTensorTrain <-> TreeTNround-trips, including aComplexF64regression that exercises the previously broken pathRoot cause
Tensor4all.jlpassed the complex site-tensor buffer length as the number of complex elements, but the Rust C API expects the number of interleavedFloat64values. That causedSimpleTTcomplex site-tensor extraction to fail withT4A_INVALID_ARGUMENT, which in turn broke theComplexF64SimpleTT and TreeTN conversion path.Validation
Passed:
julia --startup-file=no --project=/home/shinaoka/tensor4all/Tensor4all.jl -e 'using Test, Tensor4all, Tensor4all.SimpleTT; include("/home/shinaoka/tensor4all/Tensor4all.jl/test/test_simplett.jl")'julia --startup-file=no --project=/home/shinaoka/tensor4all/Tensor4all.jl -e 'using Test, Tensor4all, Tensor4all.SimpleTT, Tensor4all.TreeTN; include("/home/shinaoka/tensor4all/Tensor4all.jl/test/test_conversions.jl")'T4A_SKIP_HDF5_TESTS=1 julia --startup-file=no --project=/home/shinaoka/tensor4all/Tensor4all.jl /home/shinaoka/tensor4all/Tensor4all.jl/test/runtests.jlResult:
293 passed0 failed0 brokenRelated
main